Handle failure to launch kernel while connecting #11454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11454 +/- ##
==========================================
- Coverage 60.61% 60.59% -0.02%
==========================================
Files 612 612
Lines 33472 33472
Branches 4719 4719
==========================================
- Hits 20290 20284 -6
+ Misses 12731 12181 -550
- Partials 451 1007 +556
Continue to review full report at Codecov.
|
DonJayamanne
requested review from
IanMatthewHuff,
DavidKutu,
greazer and
rchiodo
rchiodo
reviewed
Apr 27, 2020
| session.process = process; | ||
| return session; | ||
| try { | ||
| const connectPromise = this.jmpConnection(process.connection, process); |
There was a problem hiding this comment.
jmpConnection [](start = 40, length = 13)
Looks good except you'll have conflicts with the changes I'm making.
There was a problem hiding this comment.
Depends on who gets their PR in first..
& the race beings...
IanMatthewHuff
approved these changes
Apr 27, 2020
* master: make raw kernel launch respect launching resource environment (#11463) Ensure interrupt button is always enabled (#11461) Add collapsible sections to the bug issue template (#11462) Support ipywidgets in the kernel work (#11444) Ensure isolate script is passed as command arg when installing modules (#11447) Send LS version in static enabled/ready/startup events via lazy properties (#11448) Make sure kernelSwitcher installs ipykernel (#11371)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10479