Skip to content

Add ability to pass interpreter into kernel launcher #11482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DonJayamanne
Copy link

As discussed with @IanMatthewHuff @rchiodo
Allow passing interpreter information into kernel launcher, if not passed, then spin up current interpreter as the kernel.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Apr 28, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

Codecov Report

Merging #11482 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11482      +/-   ##
==========================================
- Coverage   60.61%   60.60%   -0.02%     
==========================================
  Files         612      612              
  Lines       33472    33472              
  Branches     4719     4719              
==========================================
- Hits        20290    20285       -5     
+ Misses      12731    12181     -550     
- Partials      451     1006     +555     
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/testing/main.ts 14.38% <0.00%> (ø)
src/client/common/editor.ts 8.25% <0.00%> (ø)
src/client/linters/flake8.ts 85.71% <0.00%> (ø)
src/client/linters/pylint.ts 98.27% <0.00%> (ø)
src/client/telemetry/index.ts 85.21% <0.00%> (ø)
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7022d...8d4a0ce. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 47b722a into microsoft:master Apr 28, 2020
@DonJayamanne DonJayamanne deleted the acceptInterrpeterWhenLaunching branch April 28, 2020 21:50
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants