-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix multiroot flaky CI tests #11544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiroot flaky CI tests #11544
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11544 +/- ##
==========================================
- Coverage 60.46% 60.43% -0.03%
==========================================
Files 618 618
Lines 33776 33774 -2
Branches 4764 4763 -1
==========================================
- Hits 20421 20413 -8
- Misses 12347 12351 +4
- Partials 1008 1010 +2
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed!
|
@@ -20,7 +20,7 @@ export const multirootPath = path.join(__dirname, '..', '..', 'src', 'testMultiR | |||
const workspace3Uri = vscode.Uri.file(path.join(multirootPath, 'workspace3')); | |||
|
|||
//First thing to be executed. | |||
process.env['VSC_PYTHON_CI_TEST'] = '1'; | |||
process.env.VSC_PYTHON_CI_TEST = '1'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is magic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this make any difference? It's a noop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't change anything. It's the other line I added. The variable was not set earlier when running multiroot tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Karthik said, this is magic ✨ you explain how adding process.env.VSC_PYTHON_CI_TEST
fixes the flakiness?
@kimadeline @karthiknadig If Here's the implementation if (process.env.VSC_PYTHON_CI_TEST === '1' || isUnitTestExecution()) {
// tslint:disable:no-any
(api as any).serviceContainer = serviceContainer;
(api as any).serviceManager = serviceManager;
// tslint:enable:no-any
} So I explicitly set it before launching multiroot tests, it was already being done for single workspace and other types of tests. |
For #11477