Skip to content

Windows raw kernel launch failure fix #11603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IanMatthewHuff
Copy link
Member

For #11574

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff
Copy link
Member Author

Also added a telemetry event for timing our raw process launch. Seems like a pretty important data point to me.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented May 5, 2020

Codecov Report

Merging #11603 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11603      +/-   ##
==========================================
- Coverage   60.66%   60.64%   -0.03%     
==========================================
  Files         618      619       +1     
  Lines       33711    33713       +2     
  Branches     4742     4742              
==========================================
- Hits        20451    20445       -6     
- Misses      12275    12281       +6     
- Partials      985      987       +2     
Impacted Files Coverage Δ
src/client/telemetry/index.ts 83.65% <ø> (ø)
src/client/datascience/constants.ts 99.73% <100.00%> (+<0.01%) ⬆️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 77.01% <0.00%> (-0.58%) ⬇️
src/client/datascience/ipywidgets/constants.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed97df1...edc5896. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit f4c1ac3 into microsoft:master May 6, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/windowsLaunchFix branch May 6, 2020 14:58
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants