Fix hover stuttering. #11675
Merged
Fix hover stuttering. #11675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11675 +/- ##
==========================================
- Coverage 61.27% 60.65% -0.62%
==========================================
Files 593 627 +34
Lines 32493 33879 +1386
Branches 4594 4765 +171
==========================================
+ Hits 19910 20550 +640
- Misses 11581 12335 +754
+ Partials 1002 994 -8
Continue to review full report at Codecov.
|
DavidKutu
approved these changes
May 7, 2020
IanMatthewHuff
approved these changes
May 7, 2020
| if (!this.coordsInsideEditor(e.clientX, e.clientY)) { | ||
| // tslint:disable-next-line: no-any | ||
| const hover = this.state.editor.getContribution('editor.contrib.hover') as any; | ||
| if (hover._hideWidgets && e.clientX) { |
There was a problem hiding this comment.
Change looks good. Just wondering, why is the e.clientX needed here?
There was a problem hiding this comment.
Duh. That was a leftover when I was debugging it. I will remove.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11422
We were too aggressive in our hover closing. The bug was caused by hovering over one item closing another. This is unnecessary if inside the same window still.
Note, this isn't a regression, but while figuring out if it was a regression or not, I just fixed it instead.