Skip to content

Replace machine ID from survey with session ID #11844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2020

Conversation

luabud
Copy link
Member

@luabud luabud commented May 15, 2020

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.

@luabud luabud changed the title Replace machin ID from survey with session ID Replace machine ID from survey with session ID May 15, 2020
@luabud luabud added the no-changelog No news entry required label May 15, 2020
@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #11844 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11844      +/-   ##
==========================================
- Coverage   60.46%   60.44%   -0.03%     
==========================================
  Files         631      631              
  Lines       34158    34162       +4     
  Branches     4798     4799       +1     
==========================================
- Hits        20653    20648       -5     
  Misses      12512    12512              
- Partials      993     1002       +9     
Impacted Files Coverage Δ
src/client/activation/extensionSurvey.ts 98.38% <ø> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/logging/logger.ts 75.67% <0.00%> (-8.11%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/constants.ts 100.00% <0.00%> (ø)
src/client/logging/_console.ts 63.63% <0.00%> (ø)
src/client/logging/formatters.ts 60.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0e1b5...1f2c9ca. Read the comment docs.

@karthiknadig karthiknadig self-requested a review May 16, 2020 05:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@luabud luabud marked this pull request as ready for review May 19, 2020 17:17
@luabud luabud merged commit 1c16780 into microsoft:master May 19, 2020
@luabud luabud deleted the sessionid branch June 17, 2020 19:37
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants