Sync VSCode output Cell Output & add INotebookEditor/INotebookEditorProvider #11849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Add cell execution to the new VSC Notebooks (#11846)
DonJayamanne
requested review from
rchiodo,
DavidKutu,
greazer and
IanMatthewHuff
rchiodo
reviewed
May 16, 2020
rchiodo
reviewed
May 16, 2020
rchiodo
reviewed
May 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #11849 +/- ##
==========================================
- Coverage 60.45% 60.43% -0.03%
==========================================
Files 631 631
Lines 34162 34166 +4
Branches 4799 4800 +1
==========================================
- Hits 20653 20648 -5
- Misses 12509 12516 +7
- Partials 1000 1002 +2
Continue to review full report at Codecov.
|
| public get onExecutedCode(): Event<string> { | ||
| return this.executedCode.event; | ||
| } | ||
| public notebook?: import('../types').INotebook | undefined; |
There was a problem hiding this comment.
Interesting, didn't know you could do this.
IanMatthewHuff
approved these changes
May 18, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10496