Handling Save as of notebooks when using new VSC Notebook API
#11876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Sync VSCode output Cell Output & add INotebookEditor/INotebookEditorProvider (#11849) Do not execute shebang as an interpreter until user has clicked on the codelens enclosing the shebang (#11816) Debug and variable test failures on nightly (#11848) Add cell execution to the new VSC Notebooks (#11846) Prelimnary support to load ipyn files in native Notebook editor (#11841) Fix memleaks during tests (#11835) turn on raw kernel for insiders (#11820) Some fixes for nightly (#11802) correctly hook up session status in raw kernel (#11801) Remove waitForUpdate from tests to make them more deterministic (#11799) Fix run by line to work for restart/change kernel (#11795) Clarify that using a custom jedi also means a custom parso (#11708) Fix typo lanaguage -> language (#11720) Remove tpn (#11765) on raw kernel launch wait for ready, and have raw kernel switch respect timeout and retry (#11768) Allow azure files and only nest scrolling in notebooks (#11771)
DonJayamanne
commented
May 18, 2020
DonJayamanne
commented
May 18, 2020
DonJayamanne
commented
May 18, 2020
DonJayamanne
requested review from
rchiodo,
IanMatthewHuff,
DavidKutu and
greazer
DonJayamanne
changed the title
Save as of notebooks when using new VSC Notebook API
rchiodo
reviewed
May 18, 2020
| // tslint:disable-next-line: no-suspicious-comment | ||
| // TODO: This will not work, if we close an untitled document. | ||
| // See if we have any untitled storage already | ||
| const untitledStorage = Array.from(this.models.values()).filter(isUntitled); |
There was a problem hiding this comment.
Why not use a counter? Aren't you mimicing the existing bug with this?
There was a problem hiding this comment.
u mimicing the existing bug with this?
Yes, didn't want to fix it here. Just want to leave the bug and fix it correctly with tests. Doing that means more work at this stage.
This is being tracked, hence leaving this.
rchiodo
reviewed
May 18, 2020
IanMatthewHuff
approved these changes
May 18, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10496
Save As.Final implementation details outlined here: