Skip to content

Log digest file name when updating trust #12812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Log digest file name when updating trust #12812

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e8b62
Log digest file name
joyceerhl Jul 8, 2020
2c3ea52
Only log each notebook file once
joyceerhl Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/client/datascience/interactive-ipynb/digestStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { inject, injectable } from 'inversify';
import * as os from 'os';
import * as path from 'path';
import { Uri } from 'vscode';
import { traceError } from '../../common/logger';
import { traceError, traceInfo } from '../../common/logger';
import { isFileNotFoundError } from '../../common/platform/errors';
import { IFileSystem } from '../../common/platform/types';
import { IExtensionContext } from '../../common/types';
Expand All @@ -14,6 +14,7 @@ import { IDigestStorage } from '../types';
export class DigestStorage implements IDigestStorage {
public readonly key: Promise<string>;
private digestDir: Promise<string>;
private loggedFileLocations = new Set();

constructor(
@inject(IFileSystem) private fs: IFileSystem,
Expand All @@ -27,6 +28,10 @@ export class DigestStorage implements IDigestStorage {
const fileLocation = await this.getFileLocation(uri);
// Since the signature is a hex digest, the character 'z' is being used to delimit the start and end of a single digest
await this.fs.appendFile(fileLocation, `z${signature}z\n`);
if (!this.loggedFileLocations.has(fileLocation)) {
traceInfo(`Wrote trust for ${uri.toString()} to ${fileLocation}`);
this.loggedFileLocations.add(fileLocation);
}
}

public async containsDigest(uri: Uri, signature: string) {
Expand Down