Skip to content

Bug fix for trusted notebooks #12820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Bug fix for trusted notebooks #12820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/client/datascience/notebookStorage/baseModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ export abstract class BaseNotebookModel implements INotebookModel {
case 'version':
changed = this.updateVersionInfo(change.interpreter, change.kernelSpec);
break;
case 'updateTrust':
this._isTrusted = change.isNotebookTrusted;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to set changed here as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually hang on. Looks like you are explicitly checking for 'updateTrust' and not reporting out if changed is true. So this is just expected to be changed = false. Seems good.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so as we don't actually want to forward this change on to any listeners.

break;
default:
break;
}
Expand Down