Skip to content

Hide the gather button while a cell is executing #12981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2020
Merged

Hide the gather button while a cell is executing #12981

merged 1 commit into from
Jul 15, 2020

Conversation

DavidKutu
Copy link

As Joyce just pointed out, the gather button appears while executing. And if you have an error in your cell and manage to push the button before the cell is done executing, the cell with the error is gathered incorreclty.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu changed the title hide the gather button while a cell is executing Hide the gather button while a cell is executing Jul 15, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidKutu DavidKutu added the no-changelog No news entry required label Jul 15, 2020
joyceerhl
joyceerhl approved these changes Jul 15, 2020
View reviewed changes
Copy link

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the gather button show up on VS Code native notebooks yet?

@DavidKutu
Copy link
Author

@joyceerhl not yet

@DavidKutu DavidKutu merged commit 4cd5df9 into master Jul 15, 2020
@DavidKutu DavidKutu deleted the david/hideGatherWhileExecuting branch July 15, 2020 20:17
@DavidKutu DavidKutu mentioned this pull request Jul 15, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@joyceerhl joyceerhl joyceerhl approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@greazer greazer Awaiting requested review from greazer

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidKutu @IanMatthewHuff @rchiodo @joyceerhl