Ensure we do not switch kernel if already the same #13297
Conversation
DonJayamanne
requested review from
DavidKutu,
IanMatthewHuff,
joyceerhl,
rchiodo and
techwithtim
| @@ -57,6 +57,7 @@ export interface IKernelSelectionUsage { | |||
| export interface IKernel extends IAsyncDisposable { | |||
| readonly uri: Uri; | |||
| readonly kernelSpec?: IJupyterKernelSpec | LiveKernelModel; | |||
| readonly metadata: Readonly<KernelSelection>; | |||
There was a problem hiding this comment.
This is what i'd like to solve with the meeting I have booked.
I need the metadata property as well as the kernelSpec property.
Ideally we should have just one property that describes all of this and use that everywhere.
One type to rule them all 😄
Leaving for now, as i need to solve this issue, but will address this once we have a type or approach to generalize this into a single entity.
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| import * as fastDeepEqual from 'fast-deep-equal'; | |||
There was a problem hiding this comment.
Using this instead of using JSON.stringify as all i'm after is equality of data.
Codecov Report
@@ Coverage Diff @@
## master #13297 +/- ##
==========================================
- Coverage 59.73% 59.71% -0.03%
==========================================
Files 670 670
Lines 37289 37289
Branches 5292 5292
==========================================
- Hits 22276 22267 -9
- Misses 13879 13885 +6
- Partials 1134 1137 +3
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
For #13266
For #12189