Skip to content

Revert "Notebook undo command is same as standard undo cmd (#13293)" #13318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

DonJayamanne
Copy link

This reverts commit d7c9348.

For #13316

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #13318 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13318      +/-   ##
==========================================
- Coverage   59.73%   59.71%   -0.03%     
==========================================
  Files         670      670              
  Lines       37289    37289              
  Branches     5292     5292              
==========================================
- Hits        22276    22267       -9     
- Misses      13879    13885       +6     
- Partials     1134     1137       +3     
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c9348...73d7c9e. Read the comment docs.

@DonJayamanne DonJayamanne merged commit ddbea64 into microsoft:master Aug 6, 2020
@DonJayamanne DonJayamanne deleted the revertUndoNb branch August 6, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants