Skip to content

Support launching with the same directory as a notebook #13324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 6, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Aug 6, 2020

For #12760

Support setting the working directory for:

  • Starting jupyter
  • Running a jupyter kernel (this is done by forcing a path on the backing notebook)
  • Running a raw kernel

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #13324 into master will decrease coverage by 0.00%.
The diff coverage is 81.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13324      +/-   ##
==========================================
- Coverage   59.73%   59.72%   -0.01%     
==========================================
  Files         670      670              
  Lines       37289    37303      +14     
  Branches     5292     5296       +4     
==========================================
+ Hits        22276    22281       +5     
- Misses      13879    13884       +5     
- Partials     1134     1138       +4     
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterServer.ts 9.25% <0.00%> (ø)
...lient/datascience/jupyter/jupyterSessionManager.ts 9.03% <ø> (ø)
...ascience/jupyter/liveshare/hostJupyterExecution.ts 57.97% <ø> (ø)
...client/datascience/kernel-launcher/kernelDaemon.ts 10.90% <ø> (+0.38%) ⬆️
src/client/datascience/kernel-launcher/types.ts 23.07% <ø> (ø)
...client/datascience/raw-kernel/rawJupyterSession.ts 16.16% <0.00%> (ø)
src/client/datascience/types.ts 100.00% <ø> (ø)
...datascience/jupyter/liveshare/hostJupyterServer.ts 12.59% <33.33%> (+0.59%) ⬆️
src/client/datascience/jupyter/jupyterUtils.ts 53.57% <71.42%> (+1.39%) ⬆️
src/client/datascience/jupyter/jupyterSession.ts 76.82% <85.71%> (+2.47%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c9348...c7c9eae. Read the comment docs.

@DonJayamanne
Copy link

Hope this doesn't result in creation of some temp files or the like.

@rchiodo
Copy link
Author

rchiodo commented Aug 6, 2020

Hope this doesn't result in creation of some temp files or the like.

No it doesn't.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rchiodo
Copy link
Author

rchiodo commented Aug 6, 2020

@IanMatthewHuff did you want to take a look before I submit?

@IanMatthewHuff
Copy link
Member

@IanMatthewHuff did you want to take a look before I submit?

Sorry, got like a bazzillion balls in the air this afternoon. Just submit since you already have an approval. I'll take a look if I can. Don't want to hold it up.

@rchiodo rchiodo merged commit 9df5ef4 into master Aug 6, 2020
@rchiodo rchiodo deleted the rchiodo/cwd_launch_kernel branch August 6, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants