Split functional tests into per file so they don't run out of memory during failures #13534
Conversation
rchiodo
requested review from
DavidKutu,
DonJayamanne,
greazer,
IanMatthewHuff and
joyceerhl
| @@ -2,25 +2,36 @@ | |||
| { | |||
There was a problem hiding this comment.
THis file didn't change as much as it looks. I just formatted it.
| @@ -3449,6 +3449,7 @@ | |||
| "test:functional:perf": "node --inspect-brk ./node_modules/mocha/bin/_mocha --require source-map-support/register --config ./build/.mocha.functional.perf.json", | |||
| "test:functional:memleak": "node --inspect-brk ./node_modules/mocha/bin/_mocha --require source-map-support/register --config ./build/.mocha.functional.json", | |||
| "test:functional:cover": "npm run test:functional", | |||
| "test:functional:split": "node ./build/ci/scripts/runFunctionalTests.js", | |||
There was a problem hiding this comment.
THis was necessary to get node to have the correct environment when starting. The test-phases.yaml will run this command using npm run test:functional:split
Codecov Report
@@ Coverage Diff @@
## master #13534 +/- ##
==========================================
- Coverage 59.82% 59.71% -0.11%
==========================================
Files 670 670
Lines 37335 37425 +90
Branches 5344 5371 +27
==========================================
+ Hits 22334 22348 +14
- Misses 13847 13911 +64
- Partials 1154 1166 +12
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -263,6 +263,10 @@ export class JupyterServerBase implements INotebookServer { | |||
| throw new Error('You forgot to override createNotebookInstance'); | |||
| } | |||
|
|
|||
| protected get isDisposed(): boolean { | |||
| throw new Error('You forgot to override isDisposed'); | |||
There was a problem hiding this comment.
This class can't be abstract because the mixin stuff I use further up won't allow it. So this function is supposed to be overridden.
This gets the windows tests to run again. However there's some differences (see last run I did)
https://dev.azure.com/ms/vscode-python/_build/results?buildId=103115&view=results
I believe I also fixed the root cause of the memory problem, opening files without a workspace means we can't use relative paths in the contents manager (and crashes in it will cause an infinite loop of starting a server).