Skip to content

Fix ts failure #13545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Fix ts failure #13545

merged 1 commit into from
Aug 20, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Aug 20, 2020

This error is happening here:

TSError: ⨯ Unable to compile TypeScript:
##[error]src/client/datascience/notebook/helpers/helpers.ts(65,66): error TS2322: Type '{ name: string; } | { name: string; codemirror_mode?: string | JSONObject | undefined; file_extension?: string | undefined; mimetype?: string | undefined; pygments_lexer?: string | undefined; } | { ...; }' is not assignable to type 'ILanguageInfoMetadata | undefined'.
  Type '{ name: string; codemirror_mode?: string | JSONObject | undefined; file_extension?: string | undefined; mimetype?: string | undefined; pygments_lexer?: string | undefined; }' is not assignable to type 'ILanguageInfoMetadata'.
    Property 'codemirror_mode' is incompatible with index signature.
      Type 'string | JSONObject | undefined' is not assignable to type 'JSONValue'.
        Type 'undefined' is not assignable to type 'JSONValue'.

Caused by my submission this morning.

@rchiodo rchiodo self-assigned this Aug 20, 2020
@rchiodo rchiodo added the no-changelog No news entry required label Aug 20, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #13545 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13545      +/-   ##
==========================================
- Coverage   59.75%   59.72%   -0.03%     
==========================================
  Files         670      670              
  Lines       37410    37410              
  Branches     5369     5369              
==========================================
- Hits        22353    22344       -9     
- Misses      13895    13901       +6     
- Partials     1162     1165       +3     
Impacted Files Coverage Δ
src/client/datascience/notebook/helpers/helpers.ts 39.41% <100.00%> (ø)
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de5b03...677ac0d. Read the comment docs.

@rchiodo rchiodo merged commit 9391658 into master Aug 20, 2020
@rchiodo rchiodo deleted the rchiodo/fix_nyc branch August 20, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants