Skip to content

Fix autofixable ESLint warnings #13613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 31, 2020

Conversation

kimadeline
Copy link

For #13142

  • Ran eslint --ext ts,tsx src/* --no-error-on-unmatched-pattern --fix
  • Fixed import untildify = require('untildify'); in src/client/pythonEnvironments/discovery/locators/services/workspaceVirtualEnvService.ts that was making ESLint very confused
  • Changed the max-len (max line length) rule to be a warning instead of an error (too much red), and to ignore strings + template literals
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Aug 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #13613 into master will decrease coverage by 0.03%.
The diff coverage is 62.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13613      +/-   ##
==========================================
- Coverage   59.72%   59.68%   -0.04%     
==========================================
  Files         673      673              
  Lines       37659    37653       -6     
  Branches     5403     5403              
==========================================
- Hits        22490    22475      -15     
- Misses      14002    14008       +6     
- Partials     1167     1170       +3     
Impacted Files Coverage Δ
...c/client/pythonEnvironments/discovery/globalenv.ts 95.23% <ø> (ø)
...s/discovery/locators/services/KnownPathsService.ts 48.21% <0.00%> (-1.79%) ⬇️
...scovery/locators/services/baseVirtualEnvService.ts 28.07% <0.00%> (ø)
...overy/locators/services/globalVirtualEnvService.ts 93.10% <ø> (ø)
...nments/discovery/locators/services/hashProvider.ts 100.00% <ø> (ø)
...discovery/locators/services/pipEnvServiceHelper.ts 20.68% <0.00%> (ø)
.../pythonEnvironments/info/environmentInfoService.ts 50.00% <ø> (ø)
src/client/pythonEnvironments/info/index.ts 41.53% <ø> (ø)
src/client/pythonEnvironments/info/interpreter.ts 80.95% <ø> (ø)
src/client/pythonEnvironments/legacyIOC.ts 100.00% <ø> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e00525...0070997. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review August 26, 2020 03:25
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've left a few comments but only one is very significant: the one about too much going on per line. However, it's not a huge deal in this PR, especially since in nearly every case the original code was nearly as dense. So I'll leave it to your discretion. 😄

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kimadeline
Copy link
Author

The Mac failure is due to infrastructure (see #13608) and is not related to this PR.

@kimadeline kimadeline merged commit e7d7fdc into microsoft:master Aug 31, 2020
@kimadeline kimadeline deleted the 13142-autofixable-eslint branch August 31, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants