-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix autofixable ESLint warnings #13613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autofixable ESLint warnings #13613
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13613 +/- ##
==========================================
- Coverage 59.72% 59.68% -0.04%
==========================================
Files 673 673
Lines 37659 37653 -6
Branches 5403 5403
==========================================
- Hits 22490 22475 -15
- Misses 14002 14008 +6
- Partials 1167 1170 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've left a few comments but only one is very significant: the one about too much going on per line. However, it's not a huge deal in this PR, especially since in nearly every case the original code was nearly as dense. So I'll leave it to your discretion. 😄
src/client/pythonEnvironments/discovery/locators/services/KnownPathsService.ts
Outdated
Show resolved
Hide resolved
src/client/pythonEnvironments/discovery/locators/services/cacheableLocatorService.ts
Show resolved
Hide resolved
src/client/pythonEnvironments/discovery/locators/services/condaService.ts
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
The Mac failure is due to infrastructure (see #13608) and is not related to this PR. |
For #13142
eslint --ext ts,tsx src/* --no-error-on-unmatched-pattern --fix
import untildify = require('untildify');
insrc/client/pythonEnvironments/discovery/locators/services/workspaceVirtualEnvService.ts
that was making ESLint very confusedmax-len
(max line length) rule to be a warning instead of an error (too much red), and to ignore strings + template literalspackage-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).