Add PyEnvInfo and the other base info types for the Python environments component. #13708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * IDs for the various supported Python environments. | ||
| */ | ||
| export enum PythonEnvKind { |
There was a problem hiding this comment.
Will this be replacing EnvironmentType?
Codecov Report
@@ Coverage Diff @@
## master #13708 +/- ##
=======================================
Coverage 59.80% 59.80%
=======================================
Files 674 675 +1
Lines 37758 37796 +38
Branches 5438 5445 +7
=======================================
+ Hits 22581 22604 +23
+ Misses 14021 14017 -4
- Partials 1156 1175 +19
Continue to review full report at Codecov.
|
karthiknadig
approved these changes
Sep 1, 2020
karrtikr
approved these changes
Sep 1, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Has a news entry file (remember to thank yourself!).[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Unit tests & system/integration tests are added/updated.[ ] Test plan is updated as appropriate.[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).[ ] The wiki is updated with any design decisions/details.