Skip to content

Disable prevention of running cells when restarting #13722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

DonJayamanne
Copy link

For #13548
This PR merely fixes the bug, does not add the progress indicator.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #13722 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13722      +/-   ##
==========================================
+ Coverage   59.71%   59.80%   +0.08%     
==========================================
  Files         674      675       +1     
  Lines       37661    37796     +135     
  Branches     5404     5445      +41     
==========================================
+ Hits        22491    22604     +113     
  Misses      14017    14017              
- Partials     1153     1175      +22     
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 56.00% <0.00%> (-14.59%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/logging/levels.ts 61.11% <0.00%> (ø)
src/client/logging/logger.ts 62.74% <0.00%> (ø)
src/client/common/utils/misc.ts 73.33% <0.00%> (ø)
src/client/logging/formatters.ts 53.57% <0.00%> (ø)
src/client/logging/transports.ts 65.11% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d7fdc...5fa0642. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 7fc10b9 into microsoft:master Sep 1, 2020
@DonJayamanne DonJayamanne deleted the issue13548 branch September 1, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants