Skip to content

removed experiment code and extra setting #13900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

DavidKutu
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@rchiodo
Copy link

rchiodo commented Sep 12, 2020

Did we decide this experiment was a success? And nobody ever turned the setting on?

@rchiodo
Copy link

rchiodo commented Sep 12, 2020

How else is somebody going to change a kernel on a remote machine? Or switch to say .NET or Julia kernel?

@DavidKutu
Copy link
Author

Right, it was only supposed to disappear on local machines

@DavidKutu
Copy link
Author

I'll check telemetry for the setting on Monday, but I'm sure there were no issues about this.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2020

Codecov Report

Merging #13900 into main will decrease coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13900      +/-   ##
==========================================
- Coverage   59.87%   59.84%   -0.03%     
==========================================
  Files         693      693              
  Lines       38348    38345       -3     
  Branches     5515     5514       -1     
==========================================
- Hits        22961    22949      -12     
- Misses      14207    14213       +6     
- Partials     1180     1183       +3     
Impacted Files Coverage Δ
src/client/common/experiments/groups.ts 100.00% <ø> (ø)
src/client/common/startPage/startPage.ts 31.21% <ø> (ø)
src/client/common/types.ts 100.00% <ø> (ø)
src/client/datascience/data-viewing/dataViewer.ts 53.40% <ø> (ø)
...ient/datascience/interactive-ipynb/nativeEditor.ts 7.78% <ø> (ø)
...atascience/interactive-window/interactiveWindow.ts 9.30% <ø> (ø)
...ce/interactive-window/interactiveWindowProvider.ts 15.20% <ø> (ø)
...atascience/notebookStorage/nativeEditorProvider.ts 17.26% <ø> (ø)
src/client/datascience/types.ts 100.00% <ø> (ø)
...rc/client/datascience/webviews/webviewPanelHost.ts 50.00% <ø> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c70ca8...1d357d0. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidKutu
Copy link
Author

@rchiodo can confirm, no one ever turned the setting on.

@DavidKutu DavidKutu merged commit ea59b9f into main Sep 14, 2020
@DavidKutu DavidKutu deleted the david/removeKernelToolbarExperiment branch September 14, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants