Failing tests with spaces in path: " Activation Environment" venv tests #14207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #14207 +/- ##
==========================================
- Coverage 59.96% 59.95% -0.01%
==========================================
Files 706 706
Lines 39182 39182
Branches 5683 5683
==========================================
- Hits 23494 23493 -1
- Misses 14451 14452 +1
Partials 1237 1237
Continue to review full report at Codecov.
|
|
kimadeline
commented
Oct 1, 2020
| @@ -132,7 +132,7 @@ suite('Activation of Environments in Terminal', () => { | |||
| ): Promise<string> { | |||
| const terminal = vscode.window.createTerminal(); | |||
| await sleep(consoleInitWaitMs); | |||
| terminal.sendText(`python ${pythonFile} ${logFile}`, true); | |||
| terminal.sendText(`python ${pythonFile.toCommandArgument()} ${logFile.toCommandArgument()}`, true); | |||
There was a problem hiding this comment.
Simple quoting works too
Suggested change
| terminal.sendText(`python ${pythonFile.toCommandArgument()} ${logFile.toCommandArgument()}`, true); | |
| terminal.sendText(`python '${pythonFile}' '${logFile}'`, true); |
There was a problem hiding this comment.
toCommandArgument() is better. When we do the shell work it will be easier to find these.
|
Kudos, SonarCloud Quality Gate passed!
|
rchiodo
approved these changes
Oct 1, 2020
karthiknadig
approved these changes
Oct 1, 2020
int19h
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #14163
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).