Skip to content

Remove notifyChangesToDocument as this is no longer necessary #14237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

DonJayamanne
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020

Codecov Report

Merging #14237 into main will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14237      +/-   ##
==========================================
- Coverage   59.95%   59.93%   -0.03%     
==========================================
  Files         706      706              
  Lines       39184    39183       -1     
  Branches     5681     5681              
==========================================
- Hits        23493    23484       -9     
- Misses      14454    14459       +5     
- Partials     1237     1240       +3     
Impacted Files Coverage Δ
src/client/datascience/notebook/types.ts 100.00% <ø> (ø)
src/client/datascience/notebook/contentProvider.ts 51.16% <100.00%> (+1.16%) ⬆️
...very/locators/services/virtualenvwrapperLocator.ts 76.92% <0.00%> (-15.39%) ⬇️
src/client/common/utils/platform.ts 60.00% <0.00%> (-12.00%) ⬇️
.../pythonEnvironments/common/externalDependencies.ts 57.57% <0.00%> (-3.04%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516f5f1...46e8982. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit 8349588 into main Oct 2, 2020
@DonJayamanne DonJayamanne deleted the removeUpdates branch October 2, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants