-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use environment NB Convert #14308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use environment NB Convert #14308
Conversation
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #14308 +/- ##
==========================================
- Coverage 59.91% 59.40% -0.51%
==========================================
Files 709 712 +3
Lines 39334 40289 +955
Branches 5698 5942 +244
==========================================
+ Hits 23567 23934 +367
- Misses 14529 15085 +556
- Partials 1238 1270 +32
Continue to review full report at Codecov.
|
Finally got tests up for this. It's actually this PR here (which Rich and David already looked at) but recreated in a new branch and with tests working. |
For #14143
Trying to reopen this PR and have it actually work.
#14289
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).