Skip to content

Turn on CodeQL #14310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2020
Merged

Turn on CodeQL #14310

merged 2 commits into from
Oct 8, 2020

Conversation

brettcannon
Copy link
Member

No description provided.

@brettcannon brettcannon added the no-changelog No news entry required label Oct 7, 2020
@brettcannon brettcannon marked this pull request as draft October 7, 2020 20:57
@brettcannon
Copy link
Member Author

Waiting to see what this finds before committing it.

@brettcannon brettcannon marked this pull request as ready for review October 7, 2020 21:26
@brettcannon
Copy link
Member Author

Code is currently clean, so 👍 for considering for inclusion.

kimadeline
kimadeline approved these changes Oct 7, 2020
View reviewed changes
Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make it a required check for PRs?

@brettcannon brettcannon closed this Oct 8, 2020
@brettcannon brettcannon reopened this Oct 8, 2020
@brettcannon
Copy link
Member Author

@kimadeline we can make it required eventually, but I would rather wait to see how it acts for a little bit before doing that.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@brettcannon brettcannon merged commit c93bebf into main Oct 8, 2020
@brettcannon brettcannon deleted the codeql branch October 8, 2020 18:11
luabud pushed a commit to luabud/vscode-python that referenced this pull request Oct 26, 2020
@brettcannon @luabud
Turn on CodeQL (microsoft#14310)
a2283d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@kimadeline kimadeline kimadeline approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettcannon @rchiodo @kimadeline