Skip to content

Unpin setup-node action #14610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Unpin setup-node action #14610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 24 additions & 31 deletions .github/workflows/insiders.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ jobs:
python-version: ${{matrix.python}}

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.1
uses: actions/setup-node@v2
with:
node-version: ${{env.NODE_VERSION}}

Expand Down Expand Up @@ -355,11 +355,10 @@ jobs:
uses: azure/login@v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}

- name: Download JUPYTER VSIX
run: az storage blob download --file ${{env.VSIX_NAME_JUPYTER}} --account-name pvsc --container-name extension-builds-jupyter --name ${{env.VSIX_NAME_JUPYTER}} --auth-mode login


- name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
run: |
echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
Expand Down Expand Up @@ -421,11 +420,10 @@ jobs:
uses: azure/login@v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}

- name: Download JUPYTER VSIX
run: az storage blob download --file ${{env.VSIX_NAME_JUPYTER}} --account-name pvsc --container-name extension-builds-jupyter --name ${{env.VSIX_NAME_JUPYTER}} --auth-mode login


- name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
run: |
echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
Expand All @@ -442,7 +440,7 @@ jobs:
CODE_TESTS_WORKSPACE: ./src/testMultiRootWkspc/smokeTests
uses: GabrielBB/[email protected]
with:
run: node --no-force-async-hooks-checks ./out/test/standardTest.js
run: node --no-force-async-hooks-checks ./out/test/standardTest.js

coverage:
name: Coverage reports upload
Expand Down Expand Up @@ -479,30 +477,25 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./coverage/cobertura-coverage.xml

# Re-enable when the Jupyter extension is available
# upload:
# name: Upload VSIX to Azure Blob Storage
# runs-on: ubuntu-latest
# if: github.repository == 'microsoft/vscode-python'
# needs: [tests, smoke-tests, build-vsix]
# env:
# BLOB_CONTAINER_NAME: extension-builds
# BLOB_NAME: ms-python-insiders.vsix

# steps:
# - name: Download VSIX
# uses: actions/download-artifact@v2
# with:
# name: ${{ env.ARTIFACT_NAME_VSIX }}

# - name: Azure Login
# uses: azure/login@v1
# with:
# creds: ${{ secrets.AZURE_CREDENTIALS }}

# - name: Upload to Blob Storage
# run: az storage blob upload --file ${{ env.VSIX_NAME }} --account-name pvsc --container-name ${{ env.BLOB_CONTAINER_NAME }} --name ${{ env.BLOB_NAME }} --auth-mode login

# - name: Get URL to uploaded VSIX
# run: az storage blob url --account-name pvsc --container-name ${{ env.BLOB_CONTAINER_NAME }} --name ${{ env.BLOB_NAME }} --auth-mode login
# name: Upload VSIX to Azure Blob Storage
# runs-on: ubuntu-latest
# if: github.repository == 'microsoft/vscode-python'
# needs: [tests, smoke-tests, build-vsix]
# env:
# BLOB_CONTAINER_NAME: extension-builds
# BLOB_NAME: ms-python-insiders.vsix
# steps:
# - name: Download VSIX
# uses: actions/download-artifact@v2
# with:
# name: ${{ env.ARTIFACT_NAME_VSIX }}
# - name: Azure Login
# uses: azure/login@v1
# with:
# creds: ${{ secrets.AZURE_CREDENTIALS }}
# - name: Upload to Blob Storage
# run: az storage blob upload --file ${{ env.VSIX_NAME }} --account-name pvsc --container-name ${{ env.BLOB_CONTAINER_NAME }} --name ${{ env.BLOB_NAME }} --auth-mode login
# - name: Get URL to uploaded VSIX
# run: az storage blob url --account-name pvsc --container-name ${{ env.BLOB_CONTAINER_NAME }} --name ${{ env.BLOB_NAME }} --auth-mode login
10 changes: 4 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
python-version: ${{matrix.python}}

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.1
uses: actions/setup-node@v2
with:
node-version: ${{env.NODE_VERSION}}

Expand Down Expand Up @@ -332,11 +332,10 @@ jobs:
uses: azure/login@v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}

- name: Download JUPYTER VSIX
run: az storage blob download --file ${{env.VSIX_NAME_JUPYTER}} --account-name pvsc --container-name extension-builds-jupyter --name ${{env.VSIX_NAME_JUPYTER}} --auth-mode login


- name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
run: |
echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
Expand Down Expand Up @@ -398,11 +397,10 @@ jobs:
uses: azure/login@v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}

- name: Download JUPYTER VSIX
run: az storage blob download --file ${{env.VSIX_NAME_JUPYTER}} --account-name pvsc --container-name extension-builds-jupyter --name ${{env.VSIX_NAME_JUPYTER}} --auth-mode login


- name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
run: |
echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
Expand All @@ -419,4 +417,4 @@ jobs:
CODE_TESTS_WORKSPACE: ./src/testMultiRootWkspc/smokeTests
uses: GabrielBB/[email protected]
with:
run: node --no-force-async-hooks-checks ./out/test/standardTest.js
run: node --no-force-async-hooks-checks ./out/test/standardTest.js