Skip to content

Detect tfevent files in workspace and prompt to launch TensorBoard #14752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Nov 25, 2020
Merged

Detect tfevent files in workspace and prompt to launch TensorBoard #14752

merged 41 commits into from
Nov 25, 2020

Conversation

joyceerhl
Copy link

@joyceerhl joyceerhl commented Nov 17, 2020 •
edited
Loading

For microsoft/vscode-jupyter#314, #14807

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joyceerhl joyceerhl marked this pull request as ready for review November 20, 2020 07:04
rchiodo
rchiodo reviewed Nov 20, 2020
View reviewed changes
DonJayamanne
DonJayamanne reviewed Nov 20, 2020
View reviewed changes
DonJayamanne
DonJayamanne reviewed Nov 20, 2020
View reviewed changes
DonJayamanne
DonJayamanne reviewed Nov 20, 2020
View reviewed changes
DonJayamanne
DonJayamanne reviewed Nov 20, 2020
View reviewed changes
DonJayamanne
DonJayamanne reviewed Nov 20, 2020
View reviewed changes
IanMatthewHuff
IanMatthewHuff approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don has some legit changes to suggest, but I didn't have anything past that, so approved with those changes.

karrtikr
karrtikr suggested changes Nov 23, 2020
View reviewed changes
karrtikr
karrtikr reviewed Nov 24, 2020
View reviewed changes
Base automatically changed from launch-tensorboard to main November 25, 2020 18:21
@joyceerhl joyceerhl merged commit b20faf0 into main Nov 25, 2020
@joyceerhl joyceerhl deleted the tfeventfiles branch November 25, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@karrtikr karrtikr karrtikr approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

@kimadeline kimadeline Awaiting requested review from kimadeline

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyceerhl @IanMatthewHuff @DonJayamanne @karrtikr @rchiodo