Skip to content

Point release: cherry picks, versions and change log update. #14775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,70 @@
# Changelog

## 2020.11.2 (19 November 2020)

### Enhancements

1. Put linter prompt behind an experiment flag.
([#14760](https://github.com/Microsoft/vscode-python/issues/14760))

### Thanks

Thanks to the following projects which we fully rely on to provide some of
our features:

- [debugpy](https://pypi.org/project/debugpy/)
- [isort](https://pypi.org/project/isort/)
- [jedi](https://pypi.org/project/jedi/)
and [parso](https://pypi.org/project/parso/)
- [Microsoft Python Language Server](https://github.com/microsoft/python-language-server)
- [Pylance](https://github.com/microsoft/pylance-release)
- [exuberant ctags](http://ctags.sourceforge.net/) (user-installed)
- [rope](https://pypi.org/project/rope/) (user-installed)

Also thanks to the various projects we provide integrations with which help
make this extension useful:

- Debugging support:
[Django](https://pypi.org/project/Django/),
[Flask](https://pypi.org/project/Flask/),
[gevent](https://pypi.org/project/gevent/),
[Jinja](https://pypi.org/project/Jinja/),
[Pyramid](https://pypi.org/project/pyramid/),
[PySpark](https://pypi.org/project/pyspark/),
[Scrapy](https://pypi.org/project/Scrapy/),
[Watson](https://pypi.org/project/Watson/)
- Formatting:
[autopep8](https://pypi.org/project/autopep8/),
[black](https://pypi.org/project/black/),
[yapf](https://pypi.org/project/yapf/)
- Interpreter support:
[conda](https://conda.io/),
[direnv](https://direnv.net/),
[pipenv](https://pypi.org/project/pipenv/),
[pyenv](https://github.com/pyenv/pyenv),
[venv](https://docs.python.org/3/library/venv.html#module-venv),
[virtualenv](https://pypi.org/project/virtualenv/)
- Linting:
[bandit](https://pypi.org/project/bandit/),
[flake8](https://pypi.org/project/flake8/),
[mypy](https://pypi.org/project/mypy/),
[prospector](https://pypi.org/project/prospector/),
[pylint](https://pypi.org/project/pylint/),
[pydocstyle](https://pypi.org/project/pydocstyle/),
[pylama](https://pypi.org/project/pylama/)
- Testing:
[nose](https://pypi.org/project/nose/),
[pytest](https://pypi.org/project/pytest/),
[unittest](https://docs.python.org/3/library/unittest.html#module-unittest)

And finally thanks to the [Python](https://www.python.org/) development team and
community for creating a fantastic programming language and community to be a
part of!

## 2020.11.1 (17 November 2020)

### Enhancements

1. Replaced "pythonPath" debug configuration property with "python".
([#12462](https://github.com/Microsoft/vscode-python/issues/12462))

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "python",
"displayName": "Python",
"description": "Linting, Debugging (multi-threaded, remote), Intellisense, Jupyter Notebooks, code formatting, refactoring, unit tests, snippets, and more.",
"version": "2020.11.1",
"version": "2020.11.2",
"featureFlags": {
"usingNewInterpreterStorage": true
},
Expand Down
4 changes: 4 additions & 0 deletions package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@
"Linter.enableLinter": "Enable {0}",
"Linter.enablePylint": "You have a pylintrc file in your workspace. Do you want to enable pylint?",
"Linter.replaceWithSelectedLinter": "Multiple linters are enabled in settings. Replace with '{0}'?",
"Linter.install": "Install a linter to get error reporting.",
"Linter.installPylint": "Install pylint",
"Linter.installFlake8": "Install flake8",
"Linter.selectLinter": "Select Linter",
"Installer.noCondaOrPipInstaller": "There is no Conda or Pip installer available in the selected environment.",
"Installer.noPipInstaller": "There is no Pip installer available in the selected environment.",
"Installer.searchForHelp": "Search for help",
Expand Down
19 changes: 16 additions & 3 deletions src/client/activation/jedi/multiplexingActivator.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
import { inject, injectable } from 'inversify';
import { inject, injectable, named } from 'inversify';
import {
CancellationToken,
CompletionContext,
Expand All @@ -13,9 +13,16 @@ import {
} from 'vscode';
// tslint:disable-next-line: import-name
import { IWorkspaceService } from '../../common/application/types';
import { isTestExecution } from '../../common/constants';
import { JediLSP } from '../../common/experiments/groups';
import { IFileSystem } from '../../common/platform/types';
import { IConfigurationService, IExperimentService, Resource } from '../../common/types';
import {
BANNER_NAME_PROPOSE_LS,
IConfigurationService,
IExperimentService,
IPythonExtensionBanner,
Resource
} from '../../common/types';
import { IServiceManager } from '../../ioc/types';
import { PythonEnvironment } from '../../pythonEnvironments/info';
import { JediExtensionActivator } from '../jedi';
Expand All @@ -38,7 +45,10 @@ export class MultiplexingJediLanguageServerActivator implements ILanguageServerA

constructor(
@inject(IServiceManager) private readonly manager: IServiceManager,
@inject(IExperimentService) experimentService: IExperimentService
@inject(IExperimentService) experimentService: IExperimentService,
@inject(IPythonExtensionBanner)
@named(BANNER_NAME_PROPOSE_LS)
private proposePylancePopup: IPythonExtensionBanner
) {
// Check experiment service to see if using new Jedi LSP protocol
this.realLanguageServerPromise = experimentService.inExperiment(JediLSP.experiment).then((inExperiment) => {
Expand All @@ -56,6 +66,9 @@ export class MultiplexingJediLanguageServerActivator implements ILanguageServerA
}
public async start(resource: Resource, interpreter: PythonEnvironment | undefined): Promise<void> {
const realServer = await this.realLanguageServerPromise;
if (!isTestExecution()) {
this.proposePylancePopup.showBanner().ignoreErrors();
}
return realServer.start(resource, interpreter);
}
public activate(): void {
Expand Down
11 changes: 10 additions & 1 deletion src/client/common/experiments/groups.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ export enum DeprecatePythonPath {

// Experiment to offer switch to Pylance language server
export enum TryPylance {
experiment = 'tryPylance'
experiment = 'tryPylance',
jediPrompt1 = 'tryPylancePromptText1',
jediPrompt2 = 'tryPylancePromptText2'
}

// Experiment for the content of the tip being displayed on first extension launch:
Expand All @@ -80,3 +82,10 @@ export enum JoinMailingListPromptVariants {
export enum SendSelectionToREPL {
experiment = 'pythonSendEntireLineToREPL'
}

// Experiment to show a prompt asking users to install or select linter
export enum LinterInstallationPromptVariants {
pylintFirst = 'pythonInstallPylintButtonFirst',
flake8First = 'pythonInstallFlake8ButtonFirst',
noPrompt = 'pythonNotDisplayLinterPrompt'
}
Loading