Skip to content

Updating devcontainer.json and README.md #22984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Updating devcontainer.json and README.md #22984

merged 8 commits into from
Mar 4, 2024

Conversation

cwebster-99
Copy link
Member

  • Adding the Python Debugger extension to the devcontainer.json extensions.
  • Small hygiene updates and removing mention of built linting and formatting support on README.md.

@cwebster-99 cwebster-99 requested a review from luabud February 27, 2024 18:01
@cwebster-99 cwebster-99 added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-editor-* User-facing catch-all documentation labels Feb 27, 2024
@cwebster-99 cwebster-99 linked an issue Feb 27, 2024 that may be closed by this pull request
@vscodenpa vscodenpa added this to the March 2024 milestone Feb 27, 2024
Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any formatting references in the package.json? do we want to remove those as well

@cwebster-99
Copy link
Member Author

cwebster-99 commented Feb 27, 2024

Are there any formatting references in the package.json? do we want to remove those as well

@karthiknadig There was mention of linting and formatting support in the description which I removed. The only other place was in the categories section which I think is ok to keep for search/filtering. Thoughts?

@cwebster-99 cwebster-99 added the skip package*.json package.json and package-lock.json don't both need updating label Feb 27, 2024
package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "python",
"displayName": "Python",
"description": "IntelliSense (Pylance), Linting, Debugging (Python Debugger), code formatting, refactoring, unit tests, and more.",
"description": "IntelliSense (Pylance), Debugging (Python Debugger), refactoring, unit tests, and more.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is Linting and Formatting category below. We should remove that also right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can remove those as well. Was thinking it might be beneficial for searching and filtering but I think it makes sense to remove.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note for our future selves: at some point we may want to change this to frame this is a plugin that offers access points to many different extensions for intellisense, env management, linting, formatting, debugging etc.

Copy link
Member Author

@cwebster-99 cwebster-99 Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking on adding a section like this to the readme and mentioning the formatting, linting, etc. extensions because we currently only mention them in links at the end. Perhaps we could add it now and expand upon it?

luabud
luabud previously approved these changes Feb 28, 2024
Co-authored-by: Luciana Abud <[email protected]>
README.md Outdated
Comment on lines 19 to 27
## Extensibility

To further improve your Python development experience, you can install various extensions to extend functionality in various feature areas. These extensions are all optional and depend on your project configuration and preferences.

- [Python formatters](https://code.visualstudio.com/docs/python/formatting#_choose-a-formatter)
- [Python linters](https://code.visualstudio.com/docs/python/linting#_choose-a-linter)

If you encounter issues with any of the listed extensions, please file an issue in its corresponding repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luabud @karthiknadig Thoughts on an "extensibility" section we can add to? Open to re-naming, re-wording, etc.!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you so much!

karthiknadig
karthiknadig previously approved these changes Feb 29, 2024
@cwebster-99 cwebster-99 merged commit c548414 into main Mar 4, 2024
@cwebster-99 cwebster-99 deleted the key-locust branch March 4, 2024 19:49
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 5, 2024
- Adding the Python Debugger extension to the `devcontainer.json`
extensions.
- Small hygiene updates and removing mention of built linting and
formatting support on `README.md`.

---------

Co-authored-by: Luciana Abud <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 8, 2024
- Adding the Python Debugger extension to the `devcontainer.json`
extensions.
- Small hygiene updates and removing mention of built linting and
formatting support on `README.md`.

---------

Co-authored-by: Luciana Abud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-editor-* User-facing catch-all debt Covers everything internal: CI, testing, refactoring of the codebase, etc. documentation skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the README
4 participants