Remove old Pylance-related code #22985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debonte
requested review from
heejaechang,
DonJayamanne,
karthiknadig and
rchiodo
debonte
added
the
debt
rchiodo
reviewed
Feb 27, 2024
rchiodo
approved these changes
Feb 27, 2024
|
@karthiknadig, could you take a look at this? |
karthiknadig
approved these changes
Feb 29, 2024
DonJayamanne
approved these changes
Feb 29, 2024
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 5, 2024
Part of microsoft/vscode-jupyter#14977 Removes some effectively dead code that would only be used by very old (year+) versions of Pylance. This logic has all been moved into vscode-pylance: - Middleware to make the interactive window input box look like a notebook cell - Call to Jupyter to get pythonpath for notebooks. - Configuration hook to get `[python]` value of `editor.formatOnType`. - LSP notebook experiment
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 8, 2024
Part of microsoft/vscode-jupyter#14977 Removes some effectively dead code that would only be used by very old (year+) versions of Pylance. This logic has all been moved into vscode-pylance: - Middleware to make the interactive window input box look like a notebook cell - Call to Jupyter to get pythonpath for notebooks. - Configuration hook to get `[python]` value of `editor.formatOnType`. - LSP notebook experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of microsoft/vscode-jupyter#14977
Removes some effectively dead code that would only be used by very old (year+) versions of Pylance. This logic has all been moved into vscode-pylance:
[python]value ofeditor.formatOnType.