-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adopting Python Walkthrough edits #23214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.json
Outdated
@@ -141,7 +141,7 @@ | |||
"svg": "resources/walkthrough/create-environment.svg", | |||
"altText": "%walkthrough.step.python.createEnvironment.altText%" | |||
}, | |||
"when": "workspaceFolderCount > 0" | |||
"when": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have empty when clauses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we have always included them but I am not sure if they are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember if they are needed either, maybe Bhavya would know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove of the empty when
if you want the step to always show. No need for empty clauses.
I can consider rephrasing
Additionally, a when condition can be set to hide or show the walkthrough based on context keys.
in https://code.visualstudio.com/api/references/contribution-points#contributes.walkthroughs to make it more explicit that its optional...
@karthiknadig removed empty |
Applying edits to the pythonWalkthrough and removing experimental walkthrough.
Applying edits to the pythonWalkthrough and removing experimental walkthrough.
Applying edits to the pythonWalkthrough and removing experimental walkthrough.
Applying edits to the pythonWalkthrough and removing experimental walkthrough.
Applying edits to the pythonWalkthrough and removing experimental walkthrough.