Skip to content

Adopting Python Walkthrough edits #23214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Adopting Python Walkthrough edits #23214

merged 3 commits into from
Apr 16, 2024

Conversation

cwebster-99
Copy link
Member

@cwebster-99 cwebster-99 commented Apr 9, 2024

Applying edits to the pythonWalkthrough and removing experimental walkthrough.

@cwebster-99 cwebster-99 added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. experimenting Feature is part of an experiment area-editor-* User-facing catch-all skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary labels Apr 9, 2024
@cwebster-99 cwebster-99 requested a review from luabud April 9, 2024 23:10
package.json Outdated
@@ -141,7 +141,7 @@
"svg": "resources/walkthrough/create-environment.svg",
"altText": "%walkthrough.step.python.createEnvironment.altText%"
},
"when": "workspaceFolderCount > 0"
"when": ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have empty when clauses?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have always included them but I am not sure if they are needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if they are needed either, maybe Bhavya would know?

Copy link

@bhavyaus bhavyaus Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove of the empty when if you want the step to always show. No need for empty clauses.

I can consider rephrasing

Additionally, a when condition can be set to hide or show the walkthrough based on context keys.

in https://code.visualstudio.com/api/references/contribution-points#contributes.walkthroughs to make it more explicit that its optional...

luabud
luabud previously approved these changes Apr 12, 2024
@cwebster-99
Copy link
Member Author

cwebster-99 commented Apr 16, 2024

@karthiknadig removed empty when clauses based on Bhavya's advice

@cwebster-99 cwebster-99 merged commit f32f3b8 into main Apr 16, 2024
@cwebster-99 cwebster-99 deleted the private-thrush branch April 16, 2024 15:37
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull request May 10, 2024
Applying edits to the pythonWalkthrough and removing experimental
walkthrough.
wesm pushed a commit to posit-dev/positron that referenced this pull request May 10, 2024
Applying edits to the pythonWalkthrough and removing experimental
walkthrough.
seeM pushed a commit to posit-dev/positron that referenced this pull request May 12, 2024
Applying edits to the pythonWalkthrough and removing experimental
walkthrough.
wesm pushed a commit to posit-dev/positron that referenced this pull request May 13, 2024
Applying edits to the pythonWalkthrough and removing experimental
walkthrough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-editor-* User-facing catch-all debt Covers everything internal: CI, testing, refactoring of the codebase, etc. experimenting Feature is part of an experiment skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants