Skip to content

Bug Fix: REPL reuse and do not overwrite Jupyter's IW title #23530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024

Conversation

anthonykim1
Copy link

Resolves: #23518

Should resolve issue where opening Python REPL -> opening Jupyter IW -> sending commands to REPL were happening instead of reusing existing Python REPL

Also seems to resolve issue where Python REPL was overwriting to Jupyter's IW title.

Switching to watch onDidCloseNotebook event as suggested.

@anthonykim1 anthonykim1 self-assigned this May 30, 2024
@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels May 30, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review May 30, 2024 21:13
@anthonykim1 anthonykim1 requested a review from amunger May 30, 2024 21:13
@anthonykim1 anthonykim1 merged commit 6d88415 into microsoft:main May 30, 2024
43 of 48 checks passed
@vscodenpa vscodenpa added this to the May 2024 milestone May 30, 2024
DonJayamanne pushed a commit that referenced this pull request Jun 24, 2024
Resolves: #23518

Should resolve issue where opening Python REPL -> opening Jupyter IW ->
sending commands to REPL were happening instead of reusing existing
Python REPL

Also seems to resolve issue where Python REPL was overwriting to
Jupyter's IW title.

Switching to watch onDidCloseNotebook event as suggested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python REPL conflicts with Jupyter IW
3 participants