Skip to content

Refactor daemon pool to fallback to python service #8515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 12, 2019

Conversation

DonJayamanne
Copy link

For #7242
Refactoring to ensure we fallback to Ptyhon Execution service if daemon is not available.

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #8515 into master will decrease coverage by 0.07%.
The diff coverage is 69.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8515      +/-   ##
==========================================
- Coverage   59.11%   59.04%   -0.08%     
==========================================
  Files         510      511       +1     
  Lines       23564    23669     +105     
  Branches     3813     3823      +10     
==========================================
+ Hits        13931    13976      +45     
- Misses       8725     8773      +48     
- Partials      908      920      +12
Impacted Files Coverage Δ
src/client/common/process/types.ts 100% <ø> (ø) ⬆️
src/client/datascience/serviceRegistry.ts 0% <0%> (ø) ⬆️
src/client/datascience/constants.ts 100% <100%> (ø) ⬆️
...rc/client/common/process/pythonExecutionFactory.ts 92.98% <100%> (+39.55%) ⬆️
src/client/common/process/pythonDaemon.ts 22.55% <32.14%> (+14.86%) ⬆️
src/client/common/process/pythonDaemonPool.ts 73.27% <73.27%> (ø)
src/client/testing/serviceRegistry.ts 48.64% <0%> (-46.85%) ⬇️
src/client/testing/codeLenses/main.ts 44.44% <0%> (-33.34%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 66.66% <0%> (-33.34%) ⬇️
src/client/formatters/serviceRegistry.ts 75% <0%> (-25%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c634ffd...a9ce795. Read the comment docs.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Nov 12, 2019
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@DonJayamanne DonJayamanne marked this pull request as ready for review November 12, 2019 17:03
@DonJayamanne DonJayamanne requested a review from rchiodo November 12, 2019 17:04
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit 4303d8e into microsoft:master Nov 12, 2019
@DonJayamanne DonJayamanne deleted the daemonPool branch November 12, 2019 19:35
@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants