-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add "Run All/Debug All" dropdown picker for parametrized tests #8757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Run All/Debug All" dropdown picker for parametrized tests #8757
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8757 +/- ##
=========================================
- Coverage 58.82% 58.8% -0.03%
=========================================
Files 526 526
Lines 24563 24580 +17
Branches 3974 3976 +2
=========================================
+ Hits 14450 14454 +4
- Misses 9178 9191 +13
Partials 935 935
Continue to review full report at Codecov.
|
While trying to write a unittest for the added picker option i stumbled over something in |
In the picker unit tests two calls to getNamesAndValues are used to extract values from enums. The second call used a generic with type 'CommandSource' but as input a Type object. To be more meaningful this has been changed to 'CommandSource' so that the test checks different TestItem types against different command sources. Otherwise it would test TestItem types against TestItem types. Furthermore extracting name and value of CommandSource.commandpalette with getNamesAndValues was not successful and returned undefined. This has been fixed by assigning CommandSource.commandpalette directly to commandSource.value when this command source is evaluated.
22290c6
to
3818e14
Compare
5b5d645
to
89a9fa5
Compare
In terms of how it looks, it's great :) No clue about the code part though 😝 |
@karthiknadig as @luabud told me, that you can also look at the changes, what do you think? |
@phloose let me know if you plan on updating the tests. |
What do you mean exactly? Should i enhance the existing ones? Or test also the used I thought i wait for your feedback and if you are concerned about something i would refactor the code to your suggestions or add parts i missed/didn't think of. |
@phloose Sorry, I thought you were waiting to do the |
Actually i already made the change in 98f3316 ;) Thanks for your approval! I think in general that there should be more tests for the |
The smoke test failure is unrelated to this PR. |
@phloose We are beginning to address test gaps in the following sprints. I agree, we need tests covering |
Related to #5608
This pull requests adds a picker option (Run All/Debug All) to the dropdown that shows when clicking on the code lens for a parametrized test. That way it is possible to run/debug all test variants that belong to a parametrized tests.
Run All:

Debug All:

Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriatepackage-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)The wiki is updated with any design decisions/details.