Skip to content

Make nb metadata available to jupyter startup and kernel selection layers #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DonJayamanne
Copy link

For #8612
Make nb metadata available for code starting the notebook and selecting kernel.
This is required to ensure we select an existing kernel from the notebook metadata.

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #8784 into master will increase coverage by 0.58%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8784      +/-   ##
==========================================
+ Coverage    58.1%   58.68%   +0.58%     
==========================================
  Files         527      526       -1     
  Lines       27075    27172      +97     
  Branches     4043     4044       +1     
==========================================
+ Hits        15731    15945     +214     
+ Misses      10485    10356     -129     
- Partials      859      871      +12
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
src/client/datascience/jupyter/notebookStarter.ts 70.43% <100%> (ø) ⬆️
...ient/datascience/interactive-ipynb/nativeEditor.ts 62.66% <100%> (+0.2%) ⬆️
src/client/datascience/jupyter/jupyterExecution.ts 55.26% <60%> (-0.08%) ⬇️
src/client/interpreter/locators/helpers.ts 68.08% <0%> (-3.03%) ⬇️
...interpreter/locators/services/KnownPathsService.ts 50.94% <0%> (-2.91%) ⬇️
src/client/workspaceSymbols/parser.ts 92.37% <0%> (-0.79%) ⬇️
src/client/common/editor.ts 8.41% <0%> (-0.41%) ⬇️
src/client/common/utils/localize.ts 93.94% <0%> (-0.28%) ⬇️
src/client/providers/jediProxy.ts 23.19% <0%> (-0.16%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9411e98...dd39f63. Read the comment docs.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Nov 26, 2019
@DonJayamanne DonJayamanne changed the title Kernel spec part5 nb metadata connect Make nb metadata available to jupyter startup and kernel selection layers Nov 26, 2019
@DonJayamanne DonJayamanne marked this pull request as ready for review November 26, 2019 20:15
@DonJayamanne DonJayamanne merged commit 17b7dbe into microsoft:master Nov 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 3, 2019
@DonJayamanne DonJayamanne deleted the kernelSpecPart5NBMetadataConnect branch December 17, 2019 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants