Skip to content

Add Kernel selection picker for local and remote sessions #8873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Dec 3, 2019

For #8612

  • Add kernel selection picker for local and remote sessions
  • Picker is not integrated with Extension
  • Droppdown labels will need to be fixed
  • Submitting PR with smaller set of changes, next PR will integrate this with DS code and fix the UI where necessary. (next PR is expected to be fairly large due to integration and minor refactorings)

@DonJayamanne DonJayamanne force-pushed the kernelSpecPart7_LocalKernelSelectorDropDown branch from a8a7c3d to 3135fd1 Compare December 3, 2019 01:35
@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #8873 into master will increase coverage by 0.09%.
The diff coverage is 85.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8873      +/-   ##
==========================================
+ Coverage   57.95%   58.05%   +0.09%     
==========================================
  Files         527      529       +2     
  Lines       27526    27612      +86     
  Branches     4146     4158      +12     
==========================================
+ Hits        15954    16029      +75     
- Misses      10695    10701       +6     
- Partials      877      882       +5
Impacted Files Coverage Δ
src/client/datascience/serviceRegistry.ts 0% <0%> (ø) ⬆️
...lient/datascience/jupyter/kernels/kernelService.ts 60.3% <66.66%> (ø) ⬆️
...ient/datascience/jupyter/kernels/kernelSelector.ts 82.97% <82.97%> (ø)
...nt/datascience/jupyter/kernels/kernelSelections.ts 97.29% <97.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be1c61...f189caa. Read the comment docs.

@DonJayamanne DonJayamanne force-pushed the kernelSpecPart7_LocalKernelSelectorDropDown branch from e0fb716 to 4ddb34f Compare December 3, 2019 18:24
@DonJayamanne DonJayamanne added the no-changelog No news entry required label Dec 3, 2019
@DonJayamanne DonJayamanne force-pushed the kernelSpecPart7_LocalKernelSelectorDropDown branch from 09fe890 to 3f553ad Compare December 3, 2019 20:41
@DonJayamanne DonJayamanne changed the title Kernel selection drop down Add Kernel selection picker for local and remote sessions Dec 3, 2019
@DonJayamanne DonJayamanne marked this pull request as ready for review December 3, 2019 21:30
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit a29a8de into microsoft:master Dec 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
@DonJayamanne DonJayamanne deleted the kernelSpecPart7_LocalKernelSelectorDropDown branch December 17, 2019 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants