Skip to content

Add implementations for ctags rebuildOnStart and rebuildOnFileSave #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimadeline
Copy link

For #793

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #8889 into master will increase coverage by 0.12%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8889      +/-   ##
==========================================
+ Coverage   57.95%   58.07%   +0.12%     
==========================================
  Files         527      527              
  Lines       27532    27548      +16     
  Branches     4146     4150       +4     
==========================================
+ Hits        15955    15998      +43     
+ Misses      10700    10665      -35     
- Partials      877      885       +8
Impacted Files Coverage Δ
src/client/workspaceSymbols/main.ts 64.28% <83.33%> (+48.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434131a...a8fdfd0. Read the comment docs.

@kimadeline kimadeline requested a review from karrtikr December 4, 2019 17:54
@kimadeline kimadeline marked this pull request as ready for review December 4, 2019 17:54
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done👏
Earlier, I would've used sinon to directly mock out this.buildWorkspaceSymbols(...) method. But I assume you're testing it like this because of the testing discussion that we had?

@kimadeline kimadeline merged commit 3938bea into microsoft:master Dec 4, 2019
@kimadeline kimadeline deleted the 793-ctags-rebuildonstart-rebuildonsave branch December 4, 2019 21:15
@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants