Skip to content

Ensure event handler is bound to the right context #9705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2020

Conversation

DonJayamanne
Copy link

For #9539

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #9705 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9705      +/-   ##
=========================================
+ Coverage   60.77%   60.8%   +0.02%     
=========================================
  Files         551     551              
  Lines       29655   29661       +6     
  Branches     4483    4485       +2     
=========================================
+ Hits        18024   18036      +12     
+ Misses      10623   10617       -6     
  Partials     1008    1008
Impacted Files Coverage Δ
.../datascience/interactive-common/interactiveBase.ts 19.05% <0%> (ø) ⬆️
src/client/common/utils/platform.ts 70.58% <0%> (-5.89%) ⬇️
...ent/common/application/webPanels/webPanelServer.ts 74.64% <0%> (-3.3%) ⬇️
src/client/common/platform/types.ts 100% <0%> (ø) ⬆️
...terpreter/locators/services/condaEnvFileService.ts 86.27% <0%> (ø) ⬆️
src/client/interpreter/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/constants.ts 80% <0%> (ø) ⬆️
...rc/datascience-ui/interactive-common/transforms.ts
src/client/common/platform/fs-temp.ts 100% <0%> (ø)
src/client/common/platform/fileSystem.ts 27.09% <0%> (+0.22%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc145ac...dbe9a73. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 9e893bf into microsoft:master Jan 23, 2020
@DonJayamanne DonJayamanne deleted the issue9539 branch January 28, 2020 01:53
@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants