Fixed the focus on the interactive window #9813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when pressing ctrl +2
Codecov Report
@@ Coverage Diff @@
## master #9813 +/- ##
==========================================
+ Coverage 60.88% 61.22% +0.34%
==========================================
Files 556 563 +7
Lines 30000 30058 +58
Branches 4548 4545 -3
==========================================
+ Hits 18265 18403 +138
+ Misses 10708 10627 -81
- Partials 1027 1028 +1
Continue to review full report at Codecov.
|
DonJayamanne
requested changes
Jan 29, 2020
rchiodo
reviewed
Jan 29, 2020
rchiodo
previously requested changes
Jan 29, 2020
added 2 commits
January 30, 2020 13:26
order to give focus
rchiodo
reviewed
Jan 30, 2020
rchiodo
previously approved these changes
Jan 31, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
requested changes
Feb 4, 2020
| domDiv.focus(); | ||
|
|
||
| // send the ctrl + 1/2 message, this should put focus back on the input box | ||
| const message = createMessageEvent({ type: InteractiveWindowMessages.Activate, payload: undefined }); |
There was a problem hiding this comment.
I don't see any tests for ctrl+1 keys
There was a problem hiding this comment.
It mentions ctrl+1 key, but we're not sending such key strokes!
DonJayamanne
approved these changes
Feb 4, 2020
| domDiv.focus(); | ||
|
|
||
| // send the ctrl + 1/2 message, this should put focus back on the input box | ||
| const message = createMessageEvent({ type: InteractiveWindowMessages.Activate, payload: undefined }); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9693
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)