Fix variables on mac and linux #9897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
approved these changes
Feb 4, 2020
| // tslint:disable-next-line: no-var-requires no-require-imports | ||
| require('expose-loader?jQuery!slickgrid/lib/jquery-1.11.2.min'); | ||
| /* | ||
| WARNING: Do not change the order of these imports. |
There was a problem hiding this comment.
Sounds like a dirty & hacky solution. I'll let this approach pass this one time 🤣
DavidKutu
approved these changes
Feb 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #9897 +/- ##
==========================================
- Coverage 61.22% 61.21% -0.01%
==========================================
Files 563 564 +1
Lines 30058 30061 +3
Branches 4545 4545
==========================================
Hits 18403 18403
- Misses 10626 10629 +3
Partials 1029 1029
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
rchiodo
added a commit
that referenced
this pull request
Feb 4, 2020
* Fix regexes to work on other platforms * Fix data frame viewer * Fix linter problems Co-authored-by: Don Jayamanne <[email protected]>
rchiodo
added a commit
that referenced
this pull request
Feb 4, 2020
* Fix regexes to work on other platforms * Fix data frame viewer * Fix linter problems Co-authored-by: Don Jayamanne <[email protected]> Co-authored-by: Don Jayamanne <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly flake tests caught this and we ignored it :(
Essentially the regex for parsing results from jupyter doesn't work on linux as the unicode char is different.
Fix the regex
Also found that jquery was busted. Don figured out a way to get it back so that the DataViewers would work again.