Minor changes to dispatchers (action creators will dispatch multiple actions) #9920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
Feb 5, 2020
rchiodo
reviewed
Feb 5, 2020
Codecov Report
@@ Coverage Diff @@
## ds/custom_editor #9920 +/- ##
=====================================================
+ Coverage 0% 60.78% +60.78%
=====================================================
Files 10 564 +554
Lines 31 29882 +29851
Branches 4 4492 +4488
=====================================================
+ Hits 0 18165 +18165
- Misses 31 10722 +10691
- Partials 0 995 +995
Continue to review full report at Codecov.
|
DonJayamanne
force-pushed
the
fixDispatchers
branch
from
df0563a to
0b904af
Compare
* ds/custom_editor: (44 commits) Implement undo support for the custom editor (#9946) Change cursor style of buttons to pointer (#9989) Command to select a kernel for a Notebook (#9988) Make error lines match the original file (#9984) Display commands when necessary (#9986) add the ip argument of jupyter server for k8s container (#9977) When starting Jupyter activate conda env (#9972) Make the interactive window wrap like the native editor does (#9966) Disables the use of a terminal to activate an environment (#9967) Add tests (excluding smoke) to CI GitHub Action (#9924) fix kernel and server labels when not connected (#9965) Be more clear about the virtual environment activation instructions Update bug report template (#9957) Do not override kernels info in other notebooks (#9958) Update instructions for creating the release branch Notebook should use kernel from metadata (#9936) Disable the terminal activation experiment (#9937) Fix variable explorer when restarting a kernel (#9931) Use the autoStart server if it matches when starting a new server (#9929) Capitalize Activate.ps1 (#9911) ...
rchiodo
reviewed
Feb 8, 2020
rchiodo
reviewed
Feb 8, 2020
| @@ -502,6 +502,7 @@ export class IInteractiveWindowMapping { | |||
| public [InteractiveWindowMessages.NotebookRunAllCells]: never | undefined; | |||
| public [InteractiveWindowMessages.NotebookRunSelectedCell]: never | undefined; | |||
| public [InteractiveWindowMessages.NotebookAddCellBelow]: IAddCellAction; | |||
| public [CommonActionType.FOCUS_CELL]: ICellAndCursorAction; | |||
There was a problem hiding this comment.
You shouldn't need this anymore, right? It's not an interactive window message
There was a problem hiding this comment.
Its not an interactive window message, but used in the mapping.
There was a problem hiding this comment.
Isn't there another mapping for common action types? Seems like this is polluting the interactive window side stuff.
In reply to: 376673396 [](ancestors = 376673396)
There was a problem hiding this comment.
Ok, I'll move it out in a separate PR.
* ds/custom_editor: Fix func test in DS failing due to FS issues (#9995)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9898
For #9102
aandbkeys, old approach resulted inaandbbeing typed into the new cell that was created as a resultclassNamewas not a string but an object.