Make error lines match the original file #9984
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9984 +/- ##
==========================================
- Coverage 61.2% 61.18% -0.02%
==========================================
Files 564 564
Lines 30078 30133 +55
Branches 4550 4558 +8
==========================================
+ Hits 18408 18436 +28
- Misses 10640 10666 +26
- Partials 1030 1031 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
| // Special case file URIs | ||
| const href = payload.toString(); | ||
| if (href.startsWith('file')) { | ||
| this.openFile(href); |
There was a problem hiding this comment.
This path is all links from interactive window output I believe. Any possible reason why a notebook would want to be using a file:/// link? Like a notebook that builds a local html file that you then want to view in the browser?
Like someone trying to do this:
https://stackoverflow.com/questions/51851217/how-to-create-a-table-with-clickable-hyperlink-to-a-local-file-in-pandas-jupyt
Seems like it's maybe not a thing?
There was a problem hiding this comment.
Not sure what you're asking? file: links worked before, I just intercepted them to handle the line number stuff (oh and make sure the reuse the open editor)
There was a problem hiding this comment.
What I was trying to check was something like this in a cell:
from IPython.display import display, HTML
display(HTML('test'))
This used to route to applicationShell.openUrl
There was a problem hiding this comment.
Sorry wrong paste:
from IPython.display import display, HTML
display(HTML('<a href="file://D/test.txt">test</a>'))
There was a problem hiding this comment.
Currently with file:///D:/test.text this will open the file up. Now it will try to find a vs code editor
There was a problem hiding this comment.
Yeah and if that editor doesn't exist, it will behave like it did before? Still not sure what the concern is?
There was a problem hiding this comment.
That users want to open a new file instead of the existing one?
For #6370
Also made the error lines clickable so the user could just jump to the file. Only works on the original file though.