-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix dirty state not matching save button state #9993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Actually seems there's another issue. Updating a cell with new output and undoing doesn't work. |
src/client/datascience/interactive-ipynb/nativeEditorStorage.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## ds/custom_editor #9993 +/- ##
===================================================
Coverage ? 60.79%
===================================================
Files ? 564
Lines ? 29881
Branches ? 4492
===================================================
Hits ? 18165
Misses ? 10722
Partials ? 994 Continue to review full report at Codecov.
|
Make a 'save' point for the undo count. Looks like this is what the editor is doing.
Kudos, SonarCloud Quality Gate passed!
|
Seems like VS code is doing weird stuff here too. Now at least my internal state matches theirs. If you do this:
I think they need to change the API to allow us to set the undo stack and the dirty state. |
Undo after save can make things go negative. This is fine as redo will push it back towards zero