Convert to TypeScript #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Mar 17, 2018
lib/index.d.ts
Outdated
| @@ -0,0 +1,11 @@ | |||
| export declare enum ProcessDataFlag { | |||
There was a problem hiding this comment.
We will still want to keep ./typings/windows-process-tree.d.ts and remove this file
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
Pulling the tslint.json from xterm.js would be good https://github.com/xtermjs/xterm.js/blob/master/tslint.json (I can do this after if there are a lot of changes)
.gitignore
Outdated
| **/*.js | ||
| **/*.map | ||
| test.d.ts |
package.json
Outdated
| @@ -5,7 +5,8 @@ | |||
| "main": "lib/index.js", | |||
| "types": "typings/windows-process-tree.d.ts", | |||
| "scripts": { | |||
| "test": "mocha" | |||
| "test": "mocha", | |||
| "postinstall": "tsc -p ." | |||
There was a problem hiding this comment.
I think tsc implies tsc -p .
Let's also add these:
"prepublish": "tsc",
"watch": "tsc -w"
.gitignore
Outdated
| node_modules | ||
| **/*.js |
There was a problem hiding this comment.
To be more specific let's ignore lib and then add them back in to package.json so both the TS and JS files are published to the module https://github.com/Tyriar/node-pty/blob/ad71e8989d7613e2e439cc191ede6d5e48600f58/package.json#L15-L21
vmihdal
pushed a commit
to vmihdal/vscode-windows-process-tree
that referenced
this pull request
Aug 13, 2021
READY : Update node-pre-gyp-github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert index and test files to TypeScript