Skip to content

Use AsyncResource in Callback::Call #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2018
Merged

Use AsyncResource in Callback::Call #22

merged 1 commit into from
Mar 26, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 26, 2018

Fixes #19

@Tyriar Tyriar added this to the 0.2.0 milestone Mar 26, 2018
@Tyriar Tyriar self-assigned this Mar 26, 2018
@Tyriar Tyriar merged commit fd21e77 into master Mar 26, 2018
@Tyriar Tyriar deleted the tyriar/async branch March 26, 2018 16:34
@bpasero
Copy link
Member

bpasero commented Aug 11, 2018

@Tyriar can we bring this back for Electron 2.0.x or even 3.0.x? I have a branch for 3.0.x up: ce70879

@Tyriar
Copy link
Member Author

Tyriar commented Aug 11, 2018

@bpasero if it all works fine with the new nan 👍, we can merge in the electron-3.0.x branch once it's good

@Tyriar
Copy link
Member Author

Tyriar commented Aug 11, 2018

@bpasero I added you as a collaborator on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @bpasero