make api version configurable to support beta api #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MIchaelMainer
requested changes
Jun 15, 2020
msgraphcore/graph_session.py
Outdated
| @@ -18,11 +18,12 @@ class GraphSession(Session): | |||
| def __init__(self, | |||
| credential: TokenCredential, | |||
| scopes: [str] = ['.default'], | |||
| middleware: list = [] | |||
| middleware: list = [], | |||
| api_version: str = '1.0' | |||
There was a problem hiding this comment.
str = '1.0' becomes str = 'v1.0'
MIchaelMainer
approved these changes
Jun 16, 2020
jobala
approved these changes
Jun 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make the version of the graph rest api configurable. Currently only the
1.0api is supported. This PR would make thebetaapi available by adding a parameterapi_versionto theGraphSessionclass. The default forapi_versionwould at1.0.