Skip to content

Remove unnecessary printout #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Conversation

ski7777
Copy link
Contributor

@ski7777 ski7777 commented May 24, 2024

Overview

Remove the dangling printouts like
Response - <class 'msgraph.generated.models.calendar_permission_collection_response.CalendarPermissionCollectionResponse'>

Demo

use the class PageIterator and call next() for example by using iterate().

Testing Instructions

I think there is no testing needed

@andrueastman
Copy link
Contributor

@ski7777 Any chance you can take a look at the lintin error at https://github.com/microsoftgraph/msgraph-sdk-python-core/actions/runs/9222464350/job/25376674855?pr=577 as well?

cc @shemogumbe for final review/merge/release

@ski7777
Copy link
Contributor Author

ski7777 commented May 28, 2024

@ski7777 Any chance you can take a look at the lintin error at https://github.com/microsoftgraph/msgraph-sdk-python-core/actions/runs/9222464350/job/25376674855?pr=577 as well?

I think the issue is quite clear:

        if isinstance(response, Parsable) and not constructor_callable:
            parsable_factory = type(response)
        elif constructor_callable is None:
            parsable_factory = PageResult
        self.parsable_factory = parsable_factory

(Last line is line 70)

I'm unsure how to fix this because I did not check the code in detail yet. Maybe the code owner @shemogumbe can check on that.

@ski7777
Copy link
Contributor Author

ski7777 commented Jun 11, 2024

Any updates?

@ski7777
Copy link
Contributor Author

ski7777 commented Jun 17, 2024

@shemogumbe @samwelkanda
Can you check on that?

@ski7777
Copy link
Contributor Author

ski7777 commented Jun 18, 2024

@andrueastman Do you have information about the review state?

@baywet baywet merged commit 8ac09f7 into microsoftgraph:main Jun 19, 2024
11 checks passed
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and sorry about the delay here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants