Skip to content

Update Github actions config to use Pipenv to run tests and linter #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Feb 15, 2021
Merged

Update Github actions config to use Pipenv to run tests and linter #69

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8a35a81
Use pipenv for ci
samwelkanda Feb 2, 2021
893b2a8
Add github action workflow status badge
samwelkanda Feb 2, 2021
1d29e98
Fix github action workflow status badge
samwelkanda Feb 2, 2021
86deb70
Install dev dependencies during CI
samwelkanda Feb 2, 2021
400c0c9
Remove unnecessary ignore venv
samwelkanda Feb 5, 2021
c424d9a
Bump pylint to version 2.6.0
samwelkanda Feb 9, 2021
214e35c
Add isort for sorting python module imports
samwelkanda Feb 9, 2021
e9b50ac
Run isort to fix import structure
samwelkanda Feb 9, 2021
76f3772
Add yaof for automatic code formatting
samwelkanda Feb 9, 2021
fb306d5
Run yapf to autoformat code to pep8 standards
samwelkanda Feb 9, 2021
d306e2e
Add mypy for static type checking
samwelkanda Feb 9, 2021
cfe6181
Fix issues raised by mypy and isort
samwelkanda Feb 9, 2021
e86c79b
Ignore pylint errors related to type annotation format
samwelkanda Feb 9, 2021
90d9f7c
Remove type annotations not compatible with older versions of python
samwelkanda Feb 9, 2021
c89e7d3
Add formatting config for vscode
samwelkanda Feb 12, 2021
a1f003b
Add hooks for code checking on commit
samwelkanda Feb 12, 2021
9a95e92
Fix format conflicts
samwelkanda Feb 12, 2021
066be4a
Add import order and code format checks to CI
samwelkanda Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
pip install -r dev_requirements.txt
pip install pipenv
pipenv install --dev
- name: Lint with Pylint
run: |
pylint msgraphcore --disable=W --rcfile=.pylintrc
pipenv run pylint msgraphcore --disable=W --rcfile=.pylintrc
- name: Test with pytest
run: |
coverage run --omit 'venv/*' -m unittest discover tests/unit
coverage run --omit 'venv/*' -m unittest discover tests/integration
coverage html
pipenv run coverage run --omit 'venv/*' -m unittest discover tests/unit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary, we don't a venv folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

pipenv run coverage run --omit 'venv/*' -m unittest discover tests/integration
pipenv run coverage html
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
[![CI Actions Status](https://github.com/microsoftgraph/msgraph-sdk-python-core/workflows/msgraph-sdk-python-core/badge.svg)](https://github.com/microsoftgraph/msgraph-sdk-python-core/actions)

## Microsoft Graph Python Client Library

The Microsoft Graph Python client library is a lightweight wrapper around
Expand Down