Skip to content

replace users/me-token-to-replace with /me #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2024
Merged

replace users/me-token-to-replace with /me #694

merged 3 commits into from
Oct 2, 2024

Conversation

shemogumbe
Copy link
Contributor

Fixes #692

@shemogumbe shemogumbe requested a review from a team as a code owner October 2, 2024 10:20
@andrueastman
Copy link
Contributor

Any chance we can add a test to validate this so as to prevent a regression in future?

andrueastman
andrueastman reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can add a test to validate this so as to prevent a regression in future?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@shemogumbe
Copy link
Contributor Author

Any chance we can add a test to validate this so as to prevent a regression in future?

Done

@shemogumbe shemogumbe merged commit 39a618f into main Oct 2, 2024
13 checks passed
@shemogumbe shemogumbe deleted the shem/replace_me_token_to_replace branch October 2, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch requests are not replacing token placeholders in request URLs, resulting in bad payloads
2 participants
@shemogumbe @andrueastman