-
Notifications
You must be signed in to change notification settings - Fork 43
Feat/request context #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobala
reviewed
Apr 27, 2021
@samwelkanda Besides the questions above, what else do we need to do on this PR? Do we need to re-review with the design changes? |
…h/msgraph-sdk-python-core into experiment/request-context
Experiment/request context
jobala
approved these changes
May 26, 2021
MIchaelMainer
requested changes
May 26, 2021
MIchaelMainer
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR attaches a request context object to the native Http Request object, or Graph Request Object, to control the behavior of middleware in the Python SDK. A request context contains data that is persisted throughout the request and includes a
ClientRequestId
property,MiddlewareControl
property to control behavior of middleware as well as aFeatureUsage
property to keep track of middleware used in making the request. The request context is also be accessible to middleware components to override the options provided during middleware instantiation.Demo
Sample usage by telemetry handler to add specific headers
Notes
This design uses keyword arguments to pass request-specific options to middleware as opposed to a middleware options dictionary. Consequently, this means that per-request config for custom middleware is not supported for now.
Testing Instructions
feat/request-context
branchFixes #79
Fixes #59
Fixes #43
Fixes #17