Skip to content

Fix Batch building bugs #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Fix Batch building bugs #837

merged 3 commits into from
Feb 25, 2025

Conversation

GeorgeOG
Copy link
Contributor

@GeorgeOG GeorgeOG commented Feb 24, 2025

Overview

Brief description of what this PR does, and why it is needed.

Fixes two issues,

fixes #834
and
fixes #836

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Any chance you can double check the failing test when you run pytest after the change?

Copy link

@baywet
Copy link
Member

baywet commented Feb 25, 2025

@GeorgeOG can you please accept the CLA (see the bot's message) so we can proceed and merge this pull request?

@baywet baywet requested a review from andrueastman February 25, 2025 11:52
@GeorgeOG
Copy link
Contributor Author

@baywet just getting permission from my employer

@baywet baywet enabled auto-merge (squash) February 25, 2025 12:43
@GeorgeOG
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Palantir"

@baywet baywet merged commit a0dd3c1 into microsoftgraph:main Feb 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants